-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/cgo: add error checks for safe stack retrieval on Unix #71897
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 0302d11) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
This PR (HEAD: b803e24) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Théo Matis: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
d71df4a
to
4ef7e7c
Compare
This PR (HEAD: d71df4a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
This PR (HEAD: 4ef7e7c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Cherry Mui: Patch Set 6: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Cherry Mui: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-24T15:55:56Z","revision":"834c5adbec390344e9a13992d26dd7e4305cb9b9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Cherry Mui: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
This PR (HEAD: 82c7d83) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Théo Matis: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-24T18:27:40Z","revision":"e5b87de411f740bf1f3633fbac9b2cc3d0415ecc"} Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Cherry Mui: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
This PR (HEAD: afbb3e9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Théo Matis: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Théo Matis: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
This PR (HEAD: abce42b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756. Important tips:
|
Message from Théo Matis: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 9: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-25T06:22:15Z","revision":"4bcb984653280f9f5a7a4c1f3f894a7db25fb830"} Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Ian Lance Taylor: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 9: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/651756. |
This change introduces checks to verify the return
values of
pthread
. This improveserror detection and ensures failures in stack attribute retrieval are
caught early.
Fixes #71896