Skip to content

cmd/go: invalidate coverage report cache when coverpkg sources change #74773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/go: invalidate coverage report cache when coverpkg sources change #74773

wants to merge 1 commit into from
+180 −1

Conversation

ryancurrah
Copy link
Contributor

@ryancurrah ryancurrah commented Jul 27, 2025 •
edited
Loading

When using -coverpkg with coverage profiling, the coverage cache keys
did not include the source file hashes of the covered packages. This
could result in stale coverage reports that reference outdated line
numbers when covered package sources were modified between test runs.

This change adds a cached hash of the covered packages' source files
that gets included in the coverage cache key computation. The hash is
computed once per test execution using sync.Once to avoid redundant
file system operations across multiple test packages.

The fix ensures that coverage profiles are properly invalidated when
any source file in the covered packages changes, preventing cache
hits with stale line number references.

Fixes #74873

@ryancurrah ryancurrah mentioned this pull request Jul 27, 2025
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: bb12492) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-29T11:16:25Z","revision":"7c78557e0f55c0fbd57694af257866cdad171575"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@austinderek austinderek mentioned this pull request Aug 4, 2025
Open
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from bb12492 to f7cd72d Compare August 6, 2025 03:03
@ryancurrah ryancurrah changed the title fix(cmd/go): prevent stale coverage data when using -coverpkg with test caching fix(cmd/go): invalidate test cache when -coverpkg sources change Aug 6, 2025
@ryancurrah ryancurrah changed the title fix(cmd/go): invalidate test cache when -coverpkg sources change cmd/go: invalidate test cache when -coverpkg sources change Aug 6, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: f7cd72d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah mentioned this pull request Aug 6, 2025
Open
@gopherbot
Copy link
Contributor

Message from Ryan Currah:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from f7cd72d to cb64dbe Compare August 9, 2025 13:26
@ryancurrah ryancurrah changed the title cmd/go: invalidate test cache when -coverpkg sources change cmd/go: only invalidate coverage cache when coverpkg sources change Aug 9, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: cb64dbe) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from cb64dbe to ca629f2 Compare August 9, 2025 13:33
@ryancurrah ryancurrah changed the title cmd/go: only invalidate coverage cache when coverpkg sources change cmd/go: only invalidate coverage report cache when coverpkg sources change Aug 9, 2025
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from ca629f2 to 5e0f1be Compare August 9, 2025 13:38
@gopherbot
Copy link
Contributor

This PR (HEAD: 5e0f1be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from 5e0f1be to d0fbeeb Compare August 9, 2025 13:42
@gopherbot
Copy link
Contributor

This PR (HEAD: d0fbeeb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from d0fbeeb to e85b4c0 Compare August 9, 2025 14:07
@ryancurrah ryancurrah changed the title cmd/go: only invalidate coverage report cache when coverpkg sources change cmd/go: invalidate coverage report cache when coverpkg sources change Aug 9, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: e85b4c0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah
cmd/go: invalidate coverage report cache when coverpkg sources change
d8307ea 
When using -coverpkg with coverage profiling, the coverage cache keys
did not include the source file hashes of the covered packages. This
could result in stale coverage reports that reference outdated line
numbers when covered package sources were modified between test runs.

This change adds a cached hash of the covered packages' source files
that gets included in the coverage cache key computation. The hash is
computed once per test execution using sync.Once to avoid redundant
file system operations across multiple test packages.

The fix ensures that coverage profiles are properly invalidated when
any source file in the covered packages changes, preventing cache
hits with stale line number references.

Fixes golang#74873
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from e85b4c0 to d8307ea Compare August 13, 2025 01:21
@gopherbot
Copy link
Contributor

This PR (HEAD: d8307ea) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/go: test cache uses stale coverage data with -coverpkg
2 participants
@ryancurrah @gopherbot