Skip to content

cmd/compile/internal/ir: using reflect.TypeAssert #75099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

cmd/compile/internal/ir: using reflect.TypeAssert #75099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cmd/compile/internal/ir/dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (p *dumper) dump(x reflect.Value, depth int) {
return
}

if pos, ok := x.Interface().(src.XPos); ok {
if pos, ok := reflect.TypeAssert[src.XPos](x); ok {
p.printf("%s", base.FmtPos(pos))
return
}
Expand Down Expand Up @@ -193,7 +193,7 @@ func (p *dumper) dump(x reflect.Value, depth int) {
typ := x.Type()

isNode := false
if n, ok := x.Interface().(Node); ok {
if n, ok := reflect.TypeAssert[Node](x); ok {
isNode = true
p.printf("%s %s {", n.Op().String(), p.addr(x))
} else {
Expand Down Expand Up @@ -222,7 +222,7 @@ func (p *dumper) dump(x reflect.Value, depth int) {
omitted = true
continue // exclude zero-valued fields
}
if n, ok := x.Interface().(Nodes); ok && len(n) == 0 {
if n, ok := reflect.TypeAssert[Nodes](x); ok && len(n) == 0 {
omitted = true
continue // exclude empty Nodes slices
}
Expand Down