Skip to content

Conversation

@jasikpark
Copy link

@jasikpark jasikpark commented Nov 25, 2025

The gomobile build command wraps "go build" and parses many build
flags including "-a", but it was not actually passing the "-a" flag
through to the underlying go build command.

The "-a" flag forces a rebuild of packages and dependencies, which
is useful for ensuring clean builds when needed.

Add the missing code to pass the "-a" flag through to the go build
command when buildA is true, matching the pattern used for other
build flags like "-x" and "-gcflags".

Fixes golang/go/#76466

@gopherbot
Copy link
Contributor

This PR (HEAD: 558d52e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/724360.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/724360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/724360.
After addressing review feedback, remember to publish your drafts!

@jasikpark jasikpark changed the title Ensure -a build flag is passed to go build command x/mobile: ensure -a build flag is passed to go build command Nov 25, 2025
@jasikpark jasikpark changed the title x/mobile: ensure -a build flag is passed to go build command cmd/gomobile: ensure -a build flag is passed to go build command Nov 25, 2025
The gomobile build command wraps `go build`, and parses many build flags, but it only parses `-a` and misses actually consuming it currently. This means that forcing a rebuild of packages is not possible easily: https://pkg.go.dev/cmd/go#hdr-Compile_packages_and_dependencies
@jasikpark jasikpark changed the title cmd/gomobile: ensure -a build flag is passed to go build command x/mobile: pass -a build flag to go build command Nov 25, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: 92bbebf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/724360.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@jasikpark jasikpark changed the title x/mobile: pass -a build flag to go build command cmd/gomobile: pass -a build flag to go build command Nov 25, 2025
@jasikpark
Copy link
Author

golang/go#76466

@gopherbot
Copy link
Contributor

Message from Caleb Jasik:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/724360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hajime Hoshi:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/724360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hajime Hoshi:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/724360.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants