-
Notifications
You must be signed in to change notification settings - Fork 1k
oauth2: use strings.Builder instead of bytes.Buffer #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The former does not make a copy of the accumulated buffer to produce a string. WriteByte() is faster than WriteRune() and we are not appending non-ASCII here.
This PR (HEAD: b7845f8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/694715. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
Message from Mikhail Mazurskiy: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List
Message from Sean Liao: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-13T09:35:46Z","revision":"0ee0ccabf8d029d70509cab743c9c52c39a78a59"} Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
Message from Sean Liao: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/694715. |
The former does not make a copy of the accumulated buffer
to produce a string.
WriteByte() is faster than WriteRune() and we are not
appending non-ASCII here.