v2.0.12

goldfire · May 9, 2018 · df3aa43 · df3aa43
1 parent 6985d63
commit df3aa43
Show file tree

Hide file tree

Showing 8 changed files with 43 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 2.0.12 (May 9, 2018)
+- `FIXED` The previous Chrome deprecation fixes broke spatial positioning in Safari.
+
 ## 2.0.10 (May 5, 2018)
 - `FIXED` Fixed another Chrome deprecation warning when using panning methods ([#923](https://github.com/goldfire/howler.js/issues/923)).
 - `FIXED` Playback rate wasn't working correctly in Internet Explorer when defined in the `Howl` constructor ([#936](https://github.com/goldfire/howler.js/issues/936)).

diff --git a/dist/howler.core.min.js b/dist/howler.core.min.js
diff --git a/dist/howler.js b/dist/howler.js
@@ -1,5 +1,5 @@
 /*!
- *  howler.js v2.0.10
+ *  howler.js v2.0.12
  *  howlerjs.com
  *
  *  (c) 2013-2018, James Simpson of GoldFire Studios
@@ -2312,7 +2312,7 @@
 /*!
  *  Spatial Plugin - Adds support for stereo and 3D audio where Web Audio is supported.
  *  
- *  howler.js v2.0.10
+ *  howler.js v2.0.12
  *  howlerjs.com
  *
  *  (c) 2013-2018, James Simpson of GoldFire Studios
@@ -2539,9 +2539,13 @@
             }
 
             if (pannerType === 'spatial') {
-              sound._panner.positionX.setValueAtTime(pan, Howler.ctx.currentTime);
-              sound._panner.positionY.setValueAtTime(0, Howler.ctx.currentTime);
-              sound._panner.positionZ.setValueAtTime(0, Howler.ctx.currentTime);
+              if (typeof sound._panner.positionX !== 'undefined') {
+                sound._panner.positionX.setValueAtTime(pan, Howler.ctx.currentTime);
+                sound._panner.positionY.setValueAtTime(0, Howler.ctx.currentTime);
+                sound._panner.positionZ.setValueAtTime(0, Howler.ctx.currentTime);
+              } else {
+                sound._panner.setPosition(pan, 0, 0);
+              }
             } else {
               sound._panner.pan.setValueAtTime(pan, Howler.ctx.currentTime);
             }
@@ -2615,9 +2619,13 @@
               setupPanner(sound, 'spatial');
             }
 
-            sound._panner.positionX.setValueAtTime(x, Howler.ctx.currentTime);
-            sound._panner.positionY.setValueAtTime(y, Howler.ctx.currentTime);
-            sound._panner.positionZ.setValueAtTime(z, Howler.ctx.currentTime);
+            if (typeof sound._panner.positionX !== 'undefined') {
+              sound._panner.positionX.setValueAtTime(x, Howler.ctx.currentTime);
+              sound._panner.positionY.setValueAtTime(y, Howler.ctx.currentTime);
+              sound._panner.positionZ.setValueAtTime(z, Howler.ctx.currentTime);
+            } else {
+              sound._panner.setOrientation(x, y, z);
+            }
           }
 
           self._emit('pos', sound._id);
@@ -2912,12 +2920,22 @@
       sound._panner.refDistance = sound._pannerAttr.refDistance;
       sound._panner.rolloffFactor = sound._pannerAttr.rolloffFactor;
       sound._panner.panningModel = sound._pannerAttr.panningModel;
-      sound._panner.positionX.setValueAtTime(sound._pos[0], Howler.ctx.currentTime);
-      sound._panner.positionY.setValueAtTime(sound._pos[1], Howler.ctx.currentTime);
-      sound._panner.positionZ.setValueAtTime(sound._pos[2], Howler.ctx.currentTime);
-      sound._panner.orientationX.setValueAtTime(sound._orientation[0], Howler.ctx.currentTime);
-      sound._panner.orientationY.setValueAtTime(sound._orientation[1], Howler.ctx.currentTime);
-      sound._panner.orientationZ.setValueAtTime(sound._orientation[2], Howler.ctx.currentTime);
+
+      if (typeof sound._panner.positionX !== 'undefined') {
+        sound._panner.positionX.setValueAtTime(sound._pos[0], Howler.ctx.currentTime);
+        sound._panner.positionY.setValueAtTime(sound._pos[1], Howler.ctx.currentTime);
+        sound._panner.positionZ.setValueAtTime(sound._pos[2], Howler.ctx.currentTime);
+      } else {
+        sound._panner.setPosition(sound._pos[0], sound._pos[1], sound._pos[2]);
+      }
+
+      if (typeof sound._panner.orientationX !== 'undefined') {
+        sound._panner.orientationX.setValueAtTime(sound._orientation[0], Howler.ctx.currentTime);
+        sound._panner.orientationY.setValueAtTime(sound._orientation[1], Howler.ctx.currentTime);
+        sound._panner.orientationZ.setValueAtTime(sound._orientation[2], Howler.ctx.currentTime);
+      } else {
+        sound._panner.setOrientation(sound._orientation[0], sound._orientation[1], sound._orientation[2]);
+      }
     } else {
       sound._panner = Howler.ctx.createStereoPanner();
       sound._panner.pan.setValueAtTime(sound._stereo, Howler.ctx.currentTime);

diff --git a/dist/howler.min.js b/dist/howler.min.js
diff --git a/dist/howler.spatial.min.js b/dist/howler.spatial.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "howler",
-  "version": "2.0.10",
+  "version": "2.0.12",
   "description": "Javascript audio library for the modern web.",
   "homepage": "https://howlerjs.com",
   "keywords": [

diff --git a/src/howler.core.js b/src/howler.core.js
@@ -1,5 +1,5 @@
 /*!
- *  howler.js v2.0.10
+ *  howler.js v2.0.12
  *  howlerjs.com
  *
  *  (c) 2013-2018, James Simpson of GoldFire Studios

diff --git a/src/plugins/howler.spatial.js b/src/plugins/howler.spatial.js
@@ -1,7 +1,7 @@
 /*!
  *  Spatial Plugin - Adds support for stereo and 3D audio where Web Audio is supported.
  *  
- *  howler.js v2.0.10
+ *  howler.js v2.0.12
  *  howlerjs.com
  *
  *  (c) 2013-2018, James Simpson of GoldFire Studios