New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 21 Compatibility (Revised) #270

Open

johnnymads wants to merge 1 commit into goldmansachs:master from johnnymads:devin/1741735762-jdk21-upgrade

johnnymads commented Mar 11, 2025

JDK 21 Compatibility Upgrade (Revised)

This PR upgrades Reladomo to be compatible with JDK 21 while maintaining backward compatibility with JDK 8.

Changes Made

Updated build scripts to support JDK 21
- Modified sanity-check-build to detect JDK 9+ module system
- Updated setenv.sh to use JAVA_HOME as fallback
Added module-info.java for JDK 9+ module system support
Updated GitHub Actions workflow to test with both JDK 8 and JDK 21

Implementation Details

Added minimal JDK detection mechanism to support both JDK 8 and JDK 21
Added module-info.java with appropriate exports and requires directives
Modified build scripts to handle both JDK 8 and JDK 21 environments

Potential Breaking Changes

None. The changes maintain backward compatibility with JDK 8.

Testing

Compiled with JDK 21
All tests pass with both JDK 8 and JDK 21 in GitHub Actions

Link to Devin run: https://app.devin.ai/sessions/aa761a98c7b449aab1307cc89cc02324
Requested by: [email protected]


          Revise JDK 21 compatibility approach based on mohrezaei's feedback

e6182bd

Co-Authored-By: [email protected] <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet