Default responses #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodsonjr
force-pushed
the
default_responses
branch
5 times, most recently
from
b2b11d4 to
39a4707
Compare
This modifies the internal Response object to use either `HTTPStatus` or a string literal "default" for status codes and modifies parsing in the `Endpoint` class to match. This additionally modifies the endpoint jinja2 template to handle this alternate response status code field by using the default response, if it exists, as the fallback case instead of the UnexpectedStatus error or returning None, and modifies the return typing to match.
This ads a function test which tests whether an endpoint with a default response option generates the expected alternate typing. This also includes a regeneration of the e2e tests after adding and endpoint utilizing default responses to the base test APIs.
goodsonjr
force-pushed
the
default_responses
branch
from
39a4707 to
efd7724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.