Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity plugin] Reference the tutorial in the Unity plugin docs #2249

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

Balint-H
Copy link
Collaborator

Add a link to the mj-unity tutorial, and update the information provided to reflect the features added over time.

doc/unity.rst Outdated
complete scene recreation. This can be expensive for large models or if it happens frequently. We expect this
performance limitation to be lifted in future versions of MuJoCo.
MuJoCo library has functionality for dynamic scene editing (through `mjSpec
<https://mujoco.readthedocs.io/en/stable/programming/modeledit.html#model-editing>`_), however, this is not yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sorry. You should use an RST link here. Like this

1. The :doc:`Model Editing<programming/modeledit>` framework afforded by :ref:`mjSpec`, introduced in 3.2.0 as an

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, pushed it

doc/unity.rst Outdated
______________

The current version of the Unity package does not support loading MJCF scenes that use MuJoCo plugins such as
``elasticity``. Adding basic functionality to do this will be part of an upcoming release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at the current state? I tried to include an RST link for the engine plugin page and a html link to the repo readme.

I also added a warning as promised in #2261.

doc/unity.rst Outdated
@@ -10,6 +10,9 @@ runtime to use the MuJoCo physics engine. Users can import MJCF files and edit
relies on Unity for most aspects -- assets, game logic, simulation time -- but uses MuJoCo to determine how objects
move, giving the designer access to MuJoCo's full API.

An example project using MuJoCo's Unity plugin in a set of introductory tutorials is available at
https://github.com/Balint-H/mj-unity-tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this a proper RST link

Copy link
Collaborator Author

@Balint-H Balint-H Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple other places in the original file that uses direct urls, should I swap those as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

Copy link
Collaborator Author

@Balint-H Balint-H Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never, finally added the RST links.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the trailing whitespaces in unity.rst? There are 3, I believe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, removed.

@copybara-service copybara-service bot merged commit e2b1cfc into google-deepmind:main Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants