Adding logic for custom cameras in USD #2400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhihjoshi
changed the title
yuvaltassa
approved these changes
Feb 6, 2025
nimrod-gileadi
requested changes
Feb 20, 2025
| intensity: intensity of the light | ||
| radius: radius of the originating light source | ||
| color: color of the light | ||
| light_type: type of light source (types include "sphere", "dome") (TODO: add other light types from Omniverse) |
There was a problem hiding this comment.
Make the TODO a comment.
| # TODO: b/288149332 - Remove once USD Python Binding works well with pytype. | ||
| # pytype: disable=module-attr | ||
| from pxr import Sdf | ||
| from pxr import Usd | ||
| from pxr import UsdGeom | ||
|
|
||
| import mujoco | ||
| from mujoco import _enums |
There was a problem hiding this comment.
Use symbols from mujoco package and not these private submodules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for custom cameras.