Add defensive assertions for required keys in preprocessing - #26
Open
hgbytes wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add assertions in compute_inputs_and_labels() for for_observation/for_target - Add assertions in compute_token_types() for inputs/labels - Matches existing assertion pattern throughout codebase
hgbytes
force-pushed
the
add-preprocessing-assertions
branch
from
December 4, 2025 15:19
fe3a56e to
7385b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defensive assertions to preprocessing functions
Problem
compute_inputs_and_labels()andcompute_token_types()access dictionary keys without validation, risking uncaughtKeyErrorexceptions if called with malformed input. While currently safe (keys are always provided by callers), this creates a latent bug that surfaces only during future refactoring or code reuse.Solution
Add assertions at function entry points to validate required keys:
compute_inputs_and_labels(): Assert"for_observation"and"for_target"existcompute_token_types(): Assert"inputs"and"labels"existThis follows the codebase's existing validation pattern (assertions throughout).
Changes
compute_inputs_and_labels()(lines 59-60)compute_token_types()(lines 85-86)compute_token_types()to document required input formatpreprocessing_test.pywith 11 unit tests covering:AssertionErrorImpact
Testing