Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_training_instances to reduce for on documents #1231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fernandoasevedo
Copy link

A suggestion to remove a loop in all_documents at create_training_instances base on the following items:

  • remove len(all_documents) inside of for
  • Create a list current_document to collect non empty documents
  • Remove all_documents = [x for x in all_documents if x] because of item above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants