-
Notifications
You must be signed in to change notification settings - Fork 735
Move specification/0.8 and 0.9 to specification/v0_8 and v0_9 #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sugoi-yuzuru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a structural refactoring of the A2UI specification directories. The primary goal is to enhance clarity and consistency in versioning by adopting a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the specification directory structure by renaming specification/0.8 to specification/v0_8 and specification/0.9 to specification/v0_9. The changes correctly update references across various Python, TypeScript, JSON, and Markdown files to reflect the new paths. This is a good housekeeping change to make versioning more explicit and avoid potential issues with directory names starting with numbers. I found one minor issue with a broken link in the documentation, which I've commented on. Otherwise, the changes look solid.
| ## Further Reading | ||
|
|
||
| - **[Standard Catalog Definition](../../specification/0.9/json/standard_catalog_definition.json)**: Complete technical specification | ||
| - **[Standard Catalog Definition](../../specification/v0_9/json/standard_catalog_definition.json)**: Complete technical specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the Standard Catalog Definition for v0.9 appears to be incorrect. It points to standard_catalog_definition.json, but based on the file structure for v0.9, the correct filename is standard_catalog.json. This seems to be a copy-paste error from a v0.8 reference.
| - **[Standard Catalog Definition](../../specification/v0_9/json/standard_catalog_definition.json)**: Complete technical specification | |
| - **[Standard Catalog Definition](../../specification/v0_9/json/standard_catalog.json)**: Complete technical specification |
|
@sugoi-yuzuru What was the reason for this change? Please provide a description for PRs. |
No description provided.