Fix handling of empty parameters in parameter_overview.#361
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 14, 2025
Merged
Fix handling of empty parameters in parameter_overview.#361copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_714884571
branch
from
6dce6b9 to
d57273e
Compare
The test should not be on whether it is an empty dict, but whether after flattening it is empty.
Without this fix the added test fails with:
```
File "../py/clu/parameter_overview.py", line 156, in _get_parameter_rows
names, values = map(list, tuple(zip(*sorted(params.items()))))
^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 0)
```
PiperOrigin-RevId: 715237667
copybara-service
bot
force-pushed
the
test_714884571
branch
from
d57273e to
c139e6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of empty parameters in parameter_overview.
The test should not be on whether it is an empty dict, but whether after flattening it is empty.
Without this fix the added test fails with: