Skip to content

Update clu to use inspect.get_annotations(cls) over cls.__annotations__ #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 5, 2025
Merged

Update clu to use inspect.get_annotations(cls) over cls.__annotations__ #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clu/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def evaluate(variables_p, test_ds):
"""
from __future__ import annotations
from collections.abc import Mapping, Sequence
import inspect
from typing import Any, TypeVar, Protocol

from absl import logging
Expand Down Expand Up @@ -536,7 +537,8 @@ def empty(cls: type[C]) -> C:
_reduction_counter=_ReductionCounter(jnp.array(1, dtype=jnp.int32)),
**{
metric_name: metric.empty()
for metric_name, metric in cls.__annotations__.items()
for metric_name, metric
in inspect.get_annotations(cls, eval_str=True).items()
})

@classmethod
Expand All @@ -546,7 +548,8 @@ def _from_model_output(cls: type[C], **kwargs) -> C:
_reduction_counter=_ReductionCounter(jnp.array(1, dtype=jnp.int32)),
**{
metric_name: metric.from_model_output(**kwargs)
for metric_name, metric in cls.__annotations__.items()
for metric_name, metric
in inspect.get_annotations(cls, eval_str=True).items()
})

@classmethod
Expand Down