chore: use js-yaml instead of yaml as it's much faster on config read.#255
Merged
kalenkevich merged 1 commit intomainfrom Apr 10, 2026
Merged
chore: use js-yaml instead of yaml as it's much faster on config read.#255kalenkevich merged 1 commit intomainfrom
kalenkevich merged 1 commit intomainfrom
Conversation
ScottMansfield
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
The current YAML parser (
yamlpackage) used in the development tools is slower than alternatives when performing simple configuration reads, which can impact performance during batch loading of agent configurations.Solution:
Switched from
yamltojs-yamlindev/src/conformance/yaml_agent_loader.tsfor parsing YAML files. As discussed in eemeli/yaml#358,js-yamldemonstrates significantly better performance for basic read operations compared toyamlv2.Testing Plan
Unit Tests:
Please include a summary of passed npm test results.
I ran
npm run testand 112 of 113 test files passed. The only failure was a timeout in an E2E test (tests/e2e/routing/auto_routing_agent_test.ts > E2e Auto Routing with RoutedAgent > should route to complex agent for complex request), which appears to be a flakiness or timeout issue unrelated to the YAML parser change.Manual End-to-End (E2E) Tests:
Existing automated integration and build setup tests cover the functionality of the agent loader and ensure that configurations are still parsed correctly after switching libraries.
Checklist