Open
Conversation
944b00d to
9fccda9
Compare
9fccda9 to
5fa5c2e
Compare
5fa5c2e to
33eb2b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The ADK lacked a concrete implementation for executing code locally in a Node.js environment. While
BaseCodeExecutorprovided the structure, there was no ready-to-use executor for running JavaScript or TypeScript code blocks locally. Additionally,BaseCodeExecutorwas missing default delimiters forjavascriptandtypescriptcode blocks.Solution:
UnsafeLocalCodeExecutorincore/src/code_executors/unsafe_local_code_executor.ts. This executor:.jsfile.stdoutandstderr.BaseCodeExecutorincore/src/code_executors/base_code_executor.tsto includejavascriptandtypescriptincodeBlockDelimitersand updated documentation examples to use JavaScript.UnsafeLocalCodeExecutorfromcore/src/index.ts.core/test/code_executors/base_code_executor_test.tsto verify default values and type guards.core/test/code_executors/unsafe_local_code_executor_test.tsto verify code execution, stderr capture, and timeout behavior.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
No manual E2E tests were performed as the unit tests cover the execution logic by spawning actual Node.js processes.
Checklist