Skip to content

added more information #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

added more information #2901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/samples/adk_answering_agent/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def convert_gcs_to_https(gcs_uri: str) -> Optional[str]:
# Use the directory path if it is a index file
final_path_segment = os.path.dirname(path_after_docs)
else:
# Otherwise, use the file name without extension
# Otherwise, use the file name without extension and add a trailing slash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment is misleading. The action of adding a trailing slash does not happen on the following line (131). Instead, it is handled for all cases later in lines 133-134. The previous version of the comment was more accurate as it only described the action on line 131.

Suggested change
# Otherwise, use the file name without extension and add a trailing slash
# Otherwise, use the file name without extension

final_path_segment = path_after_docs.removesuffix(".md")

if final_path_segment and not final_path_segment.endswith("/"):
Expand Down
Loading