-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Add thought parts from litellm response #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add thought parts from litellm response #3006
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @saravanabalagi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system's ability to process and display the internal reasoning or 'thought' processes of certain AI models, specifically Deepseek and Qwen3, when their responses are routed through LiteLLM. By extracting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Hello @saravanabalagi, thank you for your contribution! Before we can review your PR, please address the following items from our contribution guidelines:
You can find more details in our contribution guidelines. Response from ADK Triaging Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for 'thought' parts from litellm
responses by processing the reasoning_content
field. The implementation is correct, but I have a suggestion to make the code more concise and efficient. More importantly, the new functionality is not covered by unit tests. I've added a comment highlighting the need to add a test case to ensure the new logic is working as expected and to prevent future regressions.
624fb1e
to
651a69b
Compare
This will probably work for most llms. It doesn't work on gpt-5 because thoughts are only emitted on the new responses api. Hopefully this will be merged soon on litellms side, so this will also work for gpt-5: BerriAI/litellm#14765 |
Hi @saravanabalagi: we are also encountering the same issue and noticed that your changes would only work for non-sse responses I think we also need to make some changes to |
Deepseek and Qwen3 models produce thought / reasoning in
Litellm already parses these think tags and the response messages contain these thought parts in the reasoning_content field. This can be parsed and added as ADK text part with thought True.
Further, this should automatically be displayed in UI and be treated the same as that of Gemini models
Fixes #1788 and #2982