Skip to content

Conversation

@jinnigu
Copy link

@jinnigu jinnigu commented Oct 23, 2025

Please ensure you have read the contribution guide before creating a pull request.

Description

Problem:
No transcription support for single agent live scenario in Python ADK.

Solution:
Add transcription support for single agent live scenario for Python ADK.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jinnigu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing feature in the Python ADK by introducing comprehensive support for audio transcription in single-agent live streaming scenarios. Previously, transcription capabilities were primarily configured for multi-agent setups. The changes ensure that single-agent live interactions can now fully leverage transcription, enhancing the functionality and consistency of the ADK's live streaming features across different agent configurations.

Highlights

  • Enable Transcription for Single-Agent Live Scenarios: The core logic for creating invocation contexts in live streaming has been updated to automatically enable audio transcription for single-agent scenarios, aligning with existing multi-agent behavior.
  • Refined Transcription Logic: The condition for applying transcription configurations has been broadened from requiring sub-agents to simply checking for the presence of a live request queue, ensuring transcription is enabled whenever a live request queue is present, regardless of the number of agents.
  • Comprehensive Unit Tests: New unit tests have been introduced to cover single-agent live streaming with transcription, including cases where transcription is implicitly enabled, explicitly configured, and when text modality is requested, ensuring robust functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the live [Component] This issue is related to live, voice and video chat label Oct 23, 2025
@adk-bot adk-bot requested a review from hangfei October 23, 2025 06:14
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds transcription support for single-agent live scenarios, which was previously only available for multi-agent setups. The core change involves modifying the condition for enabling transcription configs to apply to any live scenario. New unit tests have been added to verify this new functionality. My review has identified a significant issue where the implementation logic to enable default transcription is not being executed due to how RunConfig is defined, and the tests are passing for the wrong reasons, giving a false sense of correctness. I've provided detailed comments and suggestions to address this in both the implementation and the tests.

@jinnigu jinnigu force-pushed the feature/support-single-agent-transcription branch from 18432d0 to 3eba930 Compare October 23, 2025 07:06
@ryanaiagent ryanaiagent self-assigned this Oct 23, 2025
@ryanaiagent
Copy link
Collaborator

Hi @jinnigu, Thank you for your contribution!
We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live [Component] This issue is related to live, voice and video chat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add transcription support for single agent live scenario for Python ADK

3 participants