-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support transcription for single agent live scenario #3259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support transcription for single agent live scenario #3259
Conversation
Summary of ChangesHello @jinnigu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a missing feature in the Python ADK by introducing comprehensive support for audio transcription in single-agent live streaming scenarios. Previously, transcription capabilities were primarily configured for multi-agent setups. The changes ensure that single-agent live interactions can now fully leverage transcription, enhancing the functionality and consistency of the ADK's live streaming features across different agent configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds transcription support for single-agent live scenarios, which was previously only available for multi-agent setups. The core change involves modifying the condition for enabling transcription configs to apply to any live scenario. New unit tests have been added to verify this new functionality. My review has identified a significant issue where the implementation logic to enable default transcription is not being executed due to how RunConfig is defined, and the tests are passing for the wrong reasons, giving a false sense of correctness. I've provided detailed comments and suggestions to address this in both the implementation and the tests.
18432d0 to
3eba930
Compare
|
Hi @jinnigu, Thank you for your contribution! |
Please ensure you have read the contribution guide before creating a pull request.
Description
Problem:
No transcription support for single agent live scenario in Python ADK.
Solution:
Add transcription support for single agent live scenario for Python ADK.
Testing Plan
Unit Tests:
Checklist