Skip to content

Conversation

@UlookEE
Copy link

@UlookEE UlookEE commented Oct 24, 2025

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Fix #3231

This fix allows for more efficient interaction with Context Caching, as Context Windows are removed when they exceed N, rather than immediately when they exceed the desired number.

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link

Summary of Changes

Hello @UlookEE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the context filtering capabilities by introducing a remove_amount parameter, providing more granular control over the number of invocations to keep. It also addresses an issue with instruction placement, ensuring instructions are inserted in the correct positions within the content array. The changes are accompanied by new unit tests to validate the implemented logic.

Highlights

  • Context Filtering: Introduces a remove_amount parameter to the ContextFilterPlugin, allowing for more flexible control over context window size. It also fixes a bug where instructions were being added in the wrong place.
  • Instruction Placement: Ensures instructions are not inserted before user content or function call content in llm_request.contents.
  • Testing: Adds new unit tests for both the context filtering logic with remove_amount and the instruction placement logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Oct 24, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Oct 24, 2025

Response from ADK Triaging Agent

Hello @UlookEE, thank you for your contribution!

To help us review this PR, could you please fill out the 'Testing Plan' section in your pull request description? It would be helpful to understand how you've tested these changes. Additionally, for bug fixes, providing logs or screenshots that demonstrate the fix is effective would be very helpful for the reviewers.

Thanks!

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new remove_amount parameter to the ContextFilterPlugin to allow for more flexible context management by removing a specified number of invocations. It also includes a fix to prevent instructions from being inserted before user content or function call content in llm_flows/contents.py. Additionally, new unit tests have been added to verify the correct behavior of these changes. The review focuses on the correctness and potential edge cases of the new functionality.

@UlookEE UlookEE force-pushed the n_sized_sliding_window branch from f98b151 to 70db887 Compare October 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling explicit context caching alongside context filtering

2 participants