Enhancement: Generalise container env for agent #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
raflFaisal
force-pushed
the
raflFaisal/generaliseContainerEnvForAgent
branch
from
0b66d00 to
b7dfe64
Compare
raflFaisal
force-pushed
the
raflFaisal/generaliseContainerEnvForAgent
branch
from
b7dfe64 to
9f9e262
Compare
|
Tagging @hangfei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a flexible and extensible deployment interface for the adk deploy command to support multiple cloud providers (e.g., GCP, AWS, Kubernetes, etc.) and local Docker environments.
This proposed changes improves the adk deploy interface to be more flexible, and scalable, enabling easier integration with various cloud environments and future cloud provider support. For more details please refer this discussion
Key Changes:
Generalised Dockerfile:
Removed provider-specific hard-coded variables.
Introduced two options for injecting environment variables:
(1) Using .env files for local development.
(2)Passing environment variables directly via the adk deploy command for production environments.
Modular Deployment Interface:
(1) Introduced --cloud-provider to specify the target platform (default: gcp).
(2) Introduced --provider-args for provider-specific parameters (e.g., aws-region, project).
(3) Implemented cloud-specific deployers for each platform (e.g., GCPDeployer, AWSDeployer).
Used a factory pattern to route deployment logic based on the cloud provider.
Simplified deployment commands with clear, flexible syntax for local, GCP (AWS, k8s and other cloud providers in future)
Readme.md file is updated with usage instructions
What Will Not Be Supported:
(1) Non-containerized deployments (e.g., serverless functions).
(2) CI/CD integration.
(3) Credential management (assumes provider CLIs are pre-configured).