Skip to content

chore: Improves session update time validation message #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025

Conversation

kakao-bart-lee
Copy link
Contributor

Enhances the error message when a session's last update time is later than the storage update time. This provides better readability by formatting the timestamps in the error message.

Current error message looks like this:

ValueError: Session last_update_time 1745917432.864953 is later than the upate_time in storage 2025-04-29 18:05:57.233291

The formats are different, making it difficult for humans to read. (upate_time typos are a bonus)

ValueError: Session last_update_time 2025-04-27 14:12:37 is later than the update_time in storage 2025-04-27 13:45:00

kakao-bart-lee and others added 2 commits April 29, 2025 19:37
Enhances the error message when a session's last update time is later than the storage update time.
This provides better readability by formatting the timestamps in the error message.
@hangfei hangfei self-requested a review May 3, 2025 14:54
@hangfei hangfei added the ready to pull for importing back to Google label May 3, 2025
@hangfei hangfei merged commit 24024f7 into google:main May 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull for importing back to Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants