feat(telemetry): Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements. #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsafyan
changed the title
michaelsafyan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a narrowly focused subset of the telemetry improvements proposed in #320 . As can be seen in pull request #320, making "telemetry" into a package and moving the existing logic into a "recording" sub-package will enable the creation of a "setup" package that is focused on telemetry initialization and wiring.
Once submitted, it will become possible to begin incrementally factoring out some of the "setup"-related files and contributing them (along with associated unit tests) in more narrowly focused updates.
See also #474 for additional motivation and context.