feat(market-research-agent): add multi-agent market research sample - #1391
Conversation
|
Hi @norarfilali, @hupili, would appreciate a review when you get a chance! This adds a multi-agent market research sample using Google Places API + ADK. |
|
Hi @nikhithajoy, this PR has been open for 106 days without recent activity. Some of the files it touches have been restructured on (auto-managed by repo housekeeping — nudge id: |
|
Please take a look at the docs to learn more about the new quality standards for the samples/recipes. There has been a ton of changes and the old samples are not acceptable anymore. |
|
Hi @happyhuman,
Ran Ready for another look whenever you get a chance. Please let me know if I've missed anything from the new checklist. |
|
Great work. Thanks. Just left 1 minor comment. |
| - "Vertex AI" | ||
|
|
||
| ownership: | ||
| team: "nikhithajoy" |
There was a problem hiding this comment.
Can you please add a real team here?
There was a problem hiding this comment.
I'm contributing this as an individual, not on behalf of a formal team. Could you elaborate on what kind of team name I should add here?
There was a problem hiding this comment.
I see. The reason we introduced team was to make sure no sample/recipe will become orphaned (since we had to deal with a number of them before). We wanted to make sure a team owns the recipe in case the poc leaves. If you think you will be able to remain the owner and continue to maintain it, we can accept you as the team.
There was a problem hiding this comment.
That makes sense, thanks for explaining. Yes, I plan to remain the owner and maintain this recipe going forward.
There was a problem hiding this comment.
Oh okay. Sounds good. I will approve your PR.
Congratulations on submitting the very first recipe to our newly restructured contrib/python by the way. :-)
There was a problem hiding this comment.
Thank you so much. Really appreciate you taking the time to review and guide me.
| @@ -0,0 +1,17 @@ | |||
| # Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
Perhaps you want to change these 2025 years to 2026?
There was a problem hiding this comment.
Yeah, updated to 2026 across all files in the recipe. Please check.
Summary
Agent Details
Test plan
uv syncinstalls without errorsuv run adk webstarts the agent successfullyuv run pytest tests/ -vpasses