Test everything - #2240
Conversation
…nd integration tests
…gQuery, and analytics sub-agents
…on pipeline and infrastructure code
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…L.md pre-check steps
|
There is a problem with the Gemini CLI Correctness PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Maintainability PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Security PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Correctness PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Security PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Maintainability PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Security PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Correctness PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Maintainability PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Security PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Maintainability PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Correctness PR review. Please check the action logs for details. |
…atting in scripts
|
There is a problem with the Gemini CLI Maintainability PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Correctness PR review. Please check the action logs for details. |
|
There is a problem with the Gemini CLI Security PR review. Please check the action logs for details. |
…improve reliability
| _, project_id = google.auth.default() | ||
| os.environ.setdefault("GOOGLE_CLOUD_PROJECT", project_id) | ||
| os.environ["GOOGLE_CLOUD_LOCATION"] = "global" | ||
| os.environ.setdefault("GOOGLE_GENAI_USE_VERTEXAI", "True") |
There was a problem hiding this comment.
If no default GCP project is configured, google.auth.default() returns None for project_id, causing os.environ.setdefault to crash with a TypeError. Add a null-check on project_id before calling setdefault to prevent import-time crashes.
| ) | ||
| return "DAG conversion failed: Missing environment configuration." | ||
| try: | ||
| storage_client = storage.Client() |
There was a problem hiding this comment.
The RAG data store path is constructed using the module-level variable PROJECT_ID instead of the function parameter project_id. Update this to use project_id to avoid using an empty or incorrect project ID at runtime.
| ) | ||
| return [] | ||
|
|
||
| try: |
There was a problem hiding this comment.
If gcs_folder_uri contains no trailing path (e.g., gs://my-bucket), split('/', 1) will fail with a ValueError. Handle URIs that do not contain a path component gracefully before splitting.
| storage_client = storage.Client() | ||
|
|
||
| # Hardcode "default_collection" here. It is the required standard for Vertex Search. | ||
| vertex_ai_search_data_store_path = ( |
There was a problem hiding this comment.
The function uses the global variable PROJECT_ID to build the data store path, but initializes the client using the project_id parameter. Please consistently use the project_id parameter throughout the function to avoid scoping bugs.
…in manifest validation
…ly long naming convention
…o core/python/airflow-version-upgrade-agent
1 participant
No description provided.