fix(vsock): set guest-initiated connections to non-blocking #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In guest-initiated connections, the Unix stream socket was created in blocking mode. This caused the `uds_vsock` worker to block indefinitely when reading from the socket if the RX queue had available buffers but the host had not sent enough data to fill them. The test is also updated to use multiple buffers in the RX queue to reproduce and verify the fix. Signed-off-by: Changyuan Lyu <[email protected]>
Pull Request Test Coverage Report for Build 20979781994Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In guest-initiated connections, the Unix stream socket was created in blocking mode. This caused the
uds_vsockworker to block indefinitely when reading from the socket if the RX queue had available buffers but the host had not sent enough data to fill them.The test is also updated to use multiple buffers in the RX queue to reproduce and verify the fix.