Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle Build Tools, Update Gradle Wrapper, and Migrate JVM Toolchain to Java 17 #2784

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

niccoreyes
Copy link

@niccoreyes niccoreyes commented Feb 5, 2025

  • Upgrade Gradle build tools to version 8.7.1
  • Update Gradle wrapper to version 8.9
  • Migrate JVM toolchain from Java 11 to Java 17

Fixes #1616

Upgrade Gradle Build Tools to Version 8.7.1:

  • Updated the build.gradle.kts files to use Gradle build tools version 8.7.1.

Update Gradle Wrapper to Version 8.9:

  • Updated the gradle-wrapper.properties files to use Gradle wrapper version 8.9.

Migrate JVM Toolchain from Java 11 to Java 17:

  • Modified the build.gradle.kts files to migrate the JVM toolchain from Java 11 to Java 17.

Main changes:

edit line 36: - android-fhir\codelabs\engine\app\build.gradle.kts

from

kotlin { jvmToolchain(11) }

to

kotlin { jvmToolchain(17) }

Built using 21 LTS bundled using GRADLE_LOCAL_JAVA_HOME (default) - Android Studio 2024.2.1 Patch 1

…dules - for the JDK

- Upgrade Gradle build tools to version 8.7.1
- Update Gradle wrapper to version 8.9
- Migrate JVM toolchain from Java 11 to Java 17
@niccoreyes niccoreyes requested a review from a team as a code owner February 5, 2025 00:57
@niccoreyes niccoreyes requested a review from ktarasenko February 5, 2025 00:57
Copy link

google-cla bot commented Feb 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jingtang10 jingtang10 enabled auto-merge (squash) February 5, 2025 02:41
- Update Gradle wrapper scripts for improved POSIX shell compatibility
- Upgrade Gradle wrapper JAR
- Update Android Gradle Plugin version in engine module to 8.7.3
auto-merge was automatically disabled February 5, 2025 02:49

Head branch was pushed to by a user without write access

@jingtang10 jingtang10 enabled auto-merge (squash) February 5, 2025 03:55
auto-merge was automatically disabled February 5, 2025 06:27

Head branch was pushed to by a user without write access

@jingtang10 jingtang10 enabled auto-merge (squash) February 6, 2025 01:07
@jingtang10
Copy link
Collaborator

hey can you please run ./gradlew spotlessApply and update the pr? looks like the spotless check is failing.

auto-merge was automatically disabled February 6, 2025 05:06

Head branch was pushed to by a user without write access

@niccoreyes
Copy link
Author

hmmm merge branch was unexpected with my push from a separate machine, I'll try to investigate this in a bit; Re: e80015d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants