Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering multiple questions in the same line. #2789

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Implement column count extension.
If column count extension present then apply grid layout manager.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

Screenshot 2025-02-11 at 7 08 31 PM

@santosh-pingle
Copy link
Collaborator Author

@Itskiprotich Can you please test this and share your observations?

@Itskiprotich
Copy link
Contributor

Sure @santosh-pingle. Thanks for the tag.

@Itskiprotich
Copy link
Contributor

@santosh-pingle Thanks for this implementation. I have observed the following:

I have multiple groups, each with a fixed columnCount. When the number of items in a group exceeds this count, they should wrap to the next row. However, this behavior only applies to the first group—subsequent groups do not wrap properly.

  • Expected: Every group should respect the columnCount and wrap items correctly.
  • Actual: Only the first group wraps, while others do not.

I'm attaching here the sample Questionnaire:

layout_default.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants