Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: cr2 Chromium translation #1906

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Mar 8, 2024

Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content is reviewed.

#1463 #652

@henrif75 henrif75 marked this pull request as ready for review March 8, 2024 23:02
@kantasv
Copy link
Collaborator

kantasv commented Apr 28, 2024

Hi, @henrif75 . Thanks for raising this and I'll try to take a look into this :)

@henrif75
Copy link
Collaborator Author

Hi, @henrif75 . Thanks for raising this and I'll try to take a look into this :)

Thanks @kantasv!

@henrif75 henrif75 deleted the branch google:main May 31, 2024 17:58
@henrif75 henrif75 closed this May 31, 2024
@henrif75 henrif75 reopened this May 31, 2024
@henrif75 henrif75 changed the base branch from jp-cr2 to main May 31, 2024 18:45
@kantasv
Copy link
Collaborator

kantasv commented Jun 5, 2024

Hi Henri and JA translation team. Sorry, I don't have bandwidth to support this. Could someone take this?

@henrif75 henrif75 requested review from mgeisler and qwandor July 1, 2024 23:08
Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through the translation one more time, looking at the result with the browser. Please take a look at the comments.

Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@henrif75
Copy link
Collaborator Author

henrif75 commented Jul 5, 2024

LGTM. Thanks!

@HidenoriKobayashi

@henrif75 henrif75 merged commit 5484a0e into google:main Jul 5, 2024
34 checks passed
@henrif75 henrif75 deleted the jp-cr2-chromium branch July 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants