Diff translations on every PR #2214
Conversation
qwandor
force-pushed
the
diff
branch
2 times, most recently
from
6071734 to
d4e2e5d
Compare
| run: git checkout ${{ github.event.pull_request.base.sha }} | ||
|
|
||
| - name: Translation diff | ||
| run: i18n-report diff old-po/ po/ > $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Just to confirm, in order to see the diff, the users will need to click on the executed job and see the summary from there? It won't be visible from the PR page directly?
There is an existing action which leaves a comment within the PR. Will it be useful if a similar approach is used here?
There was a problem hiding this comment.
That's correct, it will show up in the action summary. Leaving a comment on the PR sounds like an interesting idea but looks more complicated. Would you like to send another PR to change to doing that, once this one is merged and seems to be working correctly?
There was a problem hiding this comment.
Sure, I can take look. Maybe it can be made generic enough such that the same action could be used for both.
This uses a new mode of
i18n-reportto summarise the differences in translations as an action on each PR.