Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jni_libs for JNI dependency #2637

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Use jni_libs for JNI dependency #2637

merged 1 commit into from
Feb 26, 2025

Conversation

randomPoison
Copy link
Collaborator

It looks like the module type used for adding a JNI dependency to a Java binary has changed to jni_libs. This gets our various Android examples building again, since currently the incorrect dependency causes Soong errors even if you're trying to build a different module.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I don't know what changed, but it's super nice that you update this regularly as you teach the course.

@randomPoison randomPoison merged commit 7f8596e into main Feb 26, 2025
37 checks passed
@randomPoison randomPoison deleted the legare/jni-libs-fix branch February 26, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants