Be more consistent about tests vs. main #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content slides all use `fn main`, with the exception of the testing segment. But with this change, where it makes sense exercises use tests instead, and not both tests and `fn main`. A small change in `book.js` supports running tests when a code sample does not have `fn main` but does have `#[test]`, so these work naturally. Note, however, that this doesn't work for non-editable `rust` text, as Highlightjs is responsible for running the playground in that case. This means the exercises produce `No output.` when run, but the solutions (which are editable) show the test results.
randomPoison
requested changes
Feb 14, 2025
Comment on lines
+33
to
+38
| // ANCHOR_END: solution | ||
|
|
||
| #[test] | ||
| fn test_collatz_length() { | ||
| assert_eq!(collatz_length(11), 15); | ||
| } |
There was a problem hiding this comment.
This is excluding the test from the starting code and solution, was that intended? I thought the goal was to normalize tests on using tests instead of main.
|
OK, I've reviewed all of the exercises, and made a few changes. I've also added a section in CONTRIBUTING.md regarding the choice of main or tests. Here's the summary:
|
randomPoison
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content slides all use
fn main, with the exception of the testing segment. But with this change, where it makes sense exercises use tests instead, and not both tests andfn main.A small change in
book.jssupports running tests when a code sample does not havefn mainbut does have#[test], so these work naturally.Fixes #1581.