Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pub from traits exercise #2677

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Remove pub from traits exercise #2677

merged 1 commit into from
Feb 28, 2025

Conversation

randomPoison
Copy link
Collaborator

We haven't talked about visibility at this point and the new keyword sometimes confuses students.

djmitche
djmitche approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added this to avoid unused warnings, which aren't an issue anymore..

@randomPoison randomPoison merged commit e6bab6f into main Feb 28, 2025
37 checks passed
@randomPoison randomPoison deleted the legare/methods-remove-pub branch February 28, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randomPoison @djmitche