Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the weak count to the RC diagram #2691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ColinPitrat
Copy link
Contributor

This adds the weak count in the RC diagram, and rename count to strong making it more accurate.

Copy link

google-cla bot commented Mar 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this when updating the diagram, but this, too, is actually incorrect -- the weak count is 2 in this case (if I remember correctly from that PR). This gets into more implementation detail than we really want to address in this slide, so I chose to approximate the truth and stick to the topic at hand.

The text above this diagram is incorrect, though, in that it mentions strong and weak pointers when of course they are counters.

Maybe the best approach is removing mention of weak from the slide itself (and replacing "pointers" with "counters"), and adding a speaker note indicating that the diagram isn't telling the full story, perhaps with a link to the Rc implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants