Xtask improvements #2707
Merged
Xtask improvements #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mgeisler
reviewed
Apr 7, 2025
| "install-tools" => install_tools()?, | ||
| _ => { | ||
| return Err(Box::from(get_help_string(task.as_deref()))); | ||
| return Err(anyhow!(unrecognized_task_string(task.as_str()))); |
Collaborator
There was a problem hiding this comment.
I'm surprised it should be necessary with this case? I would have expected Clap to be able to handle it for us?
We can merge this PR now, but could you look into using a Rust enum to represent the available commands? I'm pretty sure Clap can be told that a command line argument must be a valid enum variant — and so it can return an error earlier if people use an unrecognized name.
I think there is an example of what I mean here: https://docs.rs/clap/latest/clap/_cookbook/cargo_example_derive/index.html
We want each xtask (such as install-tools) to become a sub-command.
mgeisler
approved these changes
Apr 7, 2025
Collaborator
mgeisler
left a comment
mgeisler
left a comment
There was a problem hiding this comment.
Thanks @egithinji! Let's merge this now since it's a nice improvement to what we had before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to an already-merged PR (#2688) on the task automation via xtask. Main ones being: