Use fast natives in Conscrypt.#1339
Merged
Merged
Conversation
Adds @fastNative and @CriticalNative annotations to conscrypt's jni calls within NativeCrypto.java. Adds a macro for conditionally changing some native method signatures on android for CriticalNatives. Adds stubs for the annotations for the unrepackaged code. Test: presubmits and atest NativeCryptoArgTest Change-Id: Id74f960804dbdcd799e41409c7ab447b57352772
sbgoog
approved these changes
May 22, 2025
Adds @fastNative and @CriticalNative annotations to conscrypt's jni calls within NativeCrypto.java. Adds a macro for conditionally changing some native method signatures on android for CriticalNatives. Adds stubs for the annotations for the unrepackaged code. Test: presubmits and atest NativeCryptoArgTest Change-Id: Id74f960804dbdcd799e41409c7ab447b57352772
Adds @fastNative and @CriticalNative annotations to conscrypt's jni calls within NativeCrypto.java. Adds a macro for conditionally changing some native method signatures on android for CriticalNatives. Adds stubs for the annotations for the unrepackaged code. Test: presubmits and atest NativeCryptoArgTest Change-Id: Id74f960804dbdcd799e41409c7ab447b57352772
Adds @fastNative and @CriticalNative annotations to conscrypt's jni calls within NativeCrypto.java. Adds a macro for conditionally changing some native method signatures on android for CriticalNatives. Adds stubs for the annotations for the unrepackaged code. Test: presubmits and atest NativeCryptoArgTest Change-Id: Id74f960804dbdcd799e41409c7ab447b57352772
miguelaranda0
added a commit
that referenced
this pull request
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds @fastNative and @CriticalNative annotations to conscrypt's jni calls within NativeCrypto.java. Adds a macro for conditionally changing some native method signatures on android for CriticalNatives. Adds stubs for the annotations for the unrepackaged code.
Test: presubmits and atest NativeCryptoArgTest
Change-Id: Id74f960804dbdcd799e41409c7ab447b57352772