Correctly convert non-canonical public keys into XECPublicKeySpec. - #1371
Merged
Conversation
And simplify mask 1 << (255 % 8)) - 1 to 0x7f.
tweksteen
reviewed
Jul 22, 2025
tweksteen
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a X25519 public key that is in a non-canonical form is converted into a XECPublicKeySpec, the output may
be wrong. This fixes that.
We also add some tests (using the test vectors from RFC 7748, Section 5) that confirm that the conversion is now working.
We don't expect that this breaks any users, because all valid public keys should be in the canonical form.
But the RFC requires to accept keys in non-canonical form, so it is better to fix this.