Reimplement Hilt dependency validation as a task #4651
+186
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_739201752
branch
4 times, most recently
from
4e0dd23 to
8c74037
Compare
The Hilt Gradle Plugin validates that if applied Hilt's runtime and processor dependencies are also applied such that aggregated metadata is properly generated and not missed at the root. The validation was done during configuration time by inspecting dependencies but such strategy is not compatible with project isolation. This commit changes the validation strategy to be done in a task that will be wired as a dependency to other common build tasks by being a 'source generating' task that doesn't actually generate any new sources. There is no Android Gradle Plugin API to hook into the compile or assemble tasks which is why `addGeneratedSourceDirectory()` is used. Also add an Hilt Gradle Plugin option to disable the validation for project authors who which to disable it because it might not work well for their setup. Fixes #4423 RELNOTES=Fix a Gradle project isolation issue in the Hilt Gradle Plugin. PiperOrigin-RevId: 739201752
copybara-service
bot
force-pushed
the
test_739201752
branch
from
8c74037 to
9fd82e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement Hilt dependency validation as a task
The Hilt Gradle Plugin validates that if applied Hilt's runtime and processor dependencies are also applied such that aggregated metadata is properly generated and not missed at the root. The validation was done during configuration time by inspecting dependencies but such strategy is not compatible with project isolation.
This commit changes the validation strategy to be done in a task that will be wired as a dependency to other common build tasks by being a 'source generating' task that doesn't actually generate any new sources. There is no Android Gradle Plugin API to hook into the compile or assemble tasks which is why
addGeneratedSourceDirectory()is used.Also add an Hilt Gradle Plugin option to disable the validation for project authors who which to disable it because it might not work well for their setup.
Fixes #4423
RELNOTES=Fix a Gradle project isolation issue in the Hilt Gradle Plugin.