Skip to content

Adds Crashpad as a submodule from Backtrace Labs fork #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elviscapiaq merged 9 commits into from
Jan 7, 2026
Merged

Adds Crashpad as a submodule from Backtrace Labs fork #638

elviscapiaq merged 9 commits into from
Jan 7, 2026

Conversation

@elviscapiaq
Copy link
Collaborator

@elviscapiaq elviscapiaq commented Dec 5, 2025 •
edited
Loading

  • The original Google Crashpad repository does not support CMake, relying instead on Gn for building. To integrate easily, this commit uses the well-maintained Backtrace Labs fork (Apache 2.0 license).
  • A dive_crashpad library is defined to use Crashpad.

@elviscapiaq elviscapiaq force-pushed the final_crashpad branch 7 times, most recently from a3fb16a to a658095 Compare December 12, 2025 21:40
@elviscapiaq elviscapiaq force-pushed the final_crashpad branch 8 times, most recently from 1f0d423 to 73a918e Compare December 15, 2025 23:06
@elviscapiaq elviscapiaq changed the title Add Crashpad submodule and basic initialization Adds Crashpad as a submodule from backward labs + basic initialization Dec 15, 2025
@elviscapiaq elviscapiaq changed the title Adds Crashpad as a submodule from backward labs + basic initialization Adds Crashpad as a submodule from Backward labs + basic initialization Dec 15, 2025
@elviscapiaq elviscapiaq force-pushed the final_crashpad branch 6 times, most recently from a2a780a to 66dfa81 Compare December 19, 2025 01:18
elviscapiaq
elviscapiaq commented Dec 19, 2025
View reviewed changes
@elviscapiaq elviscapiaq marked this pull request as ready for review December 19, 2025 01:30
wangra-google
wangra-google reviewed Dec 19, 2025
View reviewed changes
wangra-google
wangra-google reviewed Dec 19, 2025
View reviewed changes
wangra-google
wangra-google previously approved these changes Jan 6, 2026
View reviewed changes
@elviscapiaq
Adds Crashpad as a submodule from Backward labs + initialization
93d2b0c 
- The original Google Crashpad repository does not support CMake, relying instead on Gn for building.
  To integrate easily, this commit uses the well-maintained Backtrace Labs fork (Apache 2.0 license).

- An initializer function for Crashpad is defined, preparing it for use within the Dive UI.
@elviscapiaq
Fix comments
44178ed
@elviscapiaq
Install handler for macOS
10ac388
@elviscapiaq
Create a library for dive crashpad at src/dive/crashpad
24f4097
@elviscapiaq
Fix comments
d133e4c
wangra-google
wangra-google reviewed Jan 6, 2026
View reviewed changes
wangra-google
wangra-google previously approved these changes Jan 6, 2026
View reviewed changes
wangra-google
wangra-google previously approved these changes Jan 6, 2026
View reviewed changes
angela28chen
angela28chen reviewed Jan 6, 2026
View reviewed changes
@elviscapiaq elviscapiaq changed the title Adds Crashpad as a submodule from Backward labs + basic initialization Adds Crashpad as a submodule from Backward labs + define this for Dive UI Jan 6, 2026
@elviscapiaq elviscapiaq changed the title Adds Crashpad as a submodule from Backward labs + define this for Dive UI Create a library for Crashpad from Backward labs + define this for Dive UI Jan 6, 2026
@elviscapiaq elviscapiaq changed the title Create a library for Crashpad from Backward labs + define this for Dive UI Create a library for Crashpad from Backward labs + define this for Dive UI Jan 6, 2026
@elviscapiaq elviscapiaq changed the title Create a library for Crashpad from Backward labs + define this for Dive UI Adds Crashpad as a submodule from Backtrace Labs fork Jan 6, 2026
@elviscapiaq elviscapiaq enabled auto-merge (squash) January 6, 2026 20:22
@elviscapiaq elviscapiaq disabled auto-merge January 6, 2026 20:22
@elviscapiaq elviscapiaq enabled auto-merge (squash) January 6, 2026 20:38
@elviscapiaq elviscapiaq merged commit 18c56b5 into google:main Jan 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hysw hysw hysw left review comments

@angela28chen angela28chen angela28chen approved these changes

@wangra-google wangra-google wangra-google approved these changes

@MichaelAnttila MichaelAnttila MichaelAnttila left review comments

@GrantComm GrantComm GrantComm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elviscapiaq @angela28chen @hysw @MichaelAnttila @GrantComm @wangra-google