-
Notifications
You must be signed in to change notification settings - Fork 14
[PoC] Restructure build and install folders to make it more similar across different platforms, build types, and release types #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
angela28chen
wants to merge
1
commit into
google:main
Choose a base branch
from
angela28chen:install-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21d0c3e to
280a4bc
Compare
Collaborator
Author
|
This is built on top of some stuff from #652 (namely the DIVE_INSTALL_DESTINATION changes) so need to rebase this after that is merged |
280a4bc to
1c50b64
Compare
Collaborator
Author
|
Manual Testing (2025/12/12 1:40PM)
Also the presubmits have been updated |
e5d36f9 to
d4bc467
Compare
Collaborator
Author
|
EDIT: this is outdated now Linux |
485a7ab to
9eda241
Compare
9eda241 to
857fb78
Compare
Collaborator
Author
|
Going to attempt to break this into smaller PRs for easier reviews:
Remaining changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
DIVE_ROOT/install, useDIVE_ROOT/build/pkg/<host|device>for dev builds and similarTOP_LEVEL/build/pkg/<host|device>for release binaries.Dive::ResolveDevicePath(). Refactor other areas where the same logic is being performed to use this instead