Fix the windows build error with QC extension patch #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenfengLiu
approved these changes
Dec 10, 2025
footballhead
requested changes
Dec 10, 2025
Collaborator
footballhead
left a comment
footballhead
left a comment
There was a problem hiding this comment.
dive_renderdoc doesn't use vulkan at all. It doesn't make sense to add vulkan as a dependency
Collaborator
Author
|
closing as Robin fixed the dependency from patch side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the building error on Windows after applying the QC extension patch:
