Adds Crashpad support to Dive UI #691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elviscapiaq
force-pushed
the
debug_symbols
branch
3 times, most recently
from
50a5f6b to
8186325
Compare
elviscapiaq
force-pushed
the
debug_symbols
branch
11 times, most recently
from
13f9f2e to
58afbcc
Compare
elviscapiaq
changed the title
elviscapiaq
force-pushed
the
debug_symbols
branch
from
58afbcc to
6f47f8f
Compare
- This change implements Crashpad as the primary crash reporting system across all platforms (Linux, Windows, and macOS), replacing the existing absl::crashhandler. - Symbol Generation: Developers are now required to install dump_syms via the Rust toolchain or the Linux package manager to generate debug symbols. - Symbol Uploads: Added support for uploading symbols to the Crashpad server using curl via PowerShell (Windows) or Bash (macOS/Linux). - Distribution: Included the crashpad_handler executable in the Dive UI output directory for both development and release builds. - Debug symbols are only generated and uploaded to the Crashpad server for a release build (DIVE_RELEASE_TYPE=RelWithDebInfo).
elviscapiaq
force-pushed
the
debug_symbols
branch
from
6f47f8f to
4089ee9
Compare
Collaborator
Author
|
Tested on Windows and Linux. @angela28chen @GrantComm, could you please help me test this PR on macOS? Since I’m guessing the Crashpad path dependencies for macOS, please follow this workflow:
What to verify:
If you don't see these messages, please post the error log here. On another note, could you also investigate why the Regression_StackOverflow test is failing on macOS with a timeout? My guess is that because crashpad_handler now runs out-of-process, we might need to increase the timeout. |
hysw
reviewed
Jan 12, 2026
hysw
reviewed
Jan 12, 2026
hysw
reviewed
Jan 12, 2026
hysw
reviewed
Jan 12, 2026
| - Android Studio. Make sure to install an SDK and accept the licenses. | ||
| - On Linux, set up environment variables for building GFXReconstruct as explained [here](https://github.com/LunarG/gfxreconstruct/blob/dev/BUILD.md#additional-linux-command-linux-prerequisites) | ||
| - Note: Use Java 17, because this uses an older version of Gradle. | ||
| - dump_syms, which generates debug symbols for release builds, can be installed via the [Rust installer](https://rustup.rs/). Alternatively, on Linux, you can use `sudo apt install cargo`. Once Cargo is set up, run the command `cargo install dump_syms`. |
Collaborator
There was a problem hiding this comment.
Is there a reason to not use breakpad's dump_syms? You can list both of them if both version works.
Collaborator
Author
There was a problem hiding this comment.
I have not listed that for the following reasons:
- Linux and macOS: While I successfully built
dump_symsfrom Breakpad, it does not fully support DWARF 4. As a result, function names and line numbers are not translated correctly in the stack trace. However, the Rust version is modern and provides full DWARF 4 support, allowing us to see the missing information. - Windows: Building dump_syms from breakpad source is not trivial, as it requires managing several Visual Studio prerequisites.
In any case, I believe the most reliable approach is to use the Rust version or apt for Linux.
| - Android Studio. Make sure to install an SDK and accept the licenses. | ||
| - On Linux, set up environment variables for building GFXReconstruct as explained [here](https://github.com/LunarG/gfxreconstruct/blob/dev/BUILD.md#additional-linux-command-linux-prerequisites) | ||
| - Note: Use Java 17, because this uses an older version of Gradle. | ||
| - dump_syms, which generates debug symbols for release builds, can be installed via the [Rust installer](https://rustup.rs/). Alternatively, on Linux, you can use `sudo apt install cargo`. Once Cargo is set up, run the command `cargo install dump_syms`. |
Collaborator
There was a problem hiding this comment.
On mac I did:
brew install rust
cargo install dump_syms
Collaborator
I got: Also, do I need to set something up with api key? |
Collaborator
Author
Thank you so much @angela28chen , it seems the dSYM file was not generated on macOS. Could you test again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.