Implement trigger_capture_after for gfxr_capture #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hysw
reviewed
Jan 6, 2026
footballhead
commented
Jan 6, 2026
footballhead
force-pushed
the
trigger_capture_after_gfxr_take2
branch
from
726dedd to
8aa8a4d
Compare
hysw
previously approved these changes
Jan 6, 2026
footballhead
commented
Jan 6, 2026
--trigger_capture_after is useful for automated testing. It's already
used by --comamnd pm4_capture, but I wanted to use it for --command
gfxr_capture.
Similar to the template method pattern, TriggerGfxrCapture now defines a
capture workflow with some steps that the caller can now customize.
--trigger_capture_after is now optional with default behaviors that
match the prior implementation.
For --command gfxr_capture:
- unspecified trigger_capture_after: ask for user input (old behavior)
- trigger_capture_after X: wait for X seconds before taking the
capture. Quit after the capture is retrieved
Since trigger_capture_after was also being used by --command
pm4_capture:
- unspecified trigger_capture_after: wait for 5s (the old behavior)
- trigger_capture_after X: wait for Xs (the old behavior)
footballhead
force-pushed
the
trigger_capture_after_gfxr_take2
branch
from
47f47ac to
e74aa47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--trigger_capture_after is useful for automated testing. It's already
used by --comamnd pm4_capture, but I wanted to use it for --command
gfxr_capture.
Similar to the template method pattern, TriggerGfxrCapture now defines a
capture workflow with some steps that the caller can now customize.
--trigger_capture_after is now optional with default behaviors that
match the prior implementation.
For --command gfxr_capture:
capture. Quit after the capture is retrieved
Since trigger_capture_after was also being used by --command
pm4_capture: