Rename "install/" to "pkg/" and fix macOS bundling#717
Merged
angela28chen merged 9 commits intogoogle:mainfrom Jan 16, 2026
Merged
Rename "install/" to "pkg/" and fix macOS bundling#717angela28chen merged 9 commits intogoogle:mainfrom
angela28chen merged 9 commits intogoogle:mainfrom
Conversation
…erated variables, some fixes for plugins, add search path for VS debugger use
…resubmits, changed documentation to reflect that order, fixed executable locations for the UI regression tests
Collaborator
Author
|
Should be identical to #690, just using a new PR because the old one seems to be bugged. |
footballhead
approved these changes
Jan 16, 2026
wangra-google
approved these changes
Jan 16, 2026
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
install/topkg/and have separate folders within for host tools, device resources, and pluginsCMAKE_GENERATED_INSTALL_DIR_PATHand predict the location of different resources relative to the location of the host tool.device_resourceslibrary to expose relatedCMAKE_GENERATED_*values, to try and keep fewer libraries regenerated upon SHA changingBUILD.mdto reference scripts rather than repeat their contentsPSAs:
dive_profiling_pluginand other external plugins should be copy pasted intopkg/plugins/now. Best is to do this step when setting up repo & don't deletepkg/pluginswhile rebuilding