Repository navigation
Ceil integer attributes in undiscretize when clip_to_range is False - #233
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/994011854
branch
3 times, most recently
from
October 6, 2026 01:21
7e5cb2e to
e96040c
Compare
… undiscretize. PiperOrigin-RevId: 994033957
copybara-service
Bot
force-pushed
the
cl/994011854
branch
from
October 6, 2026 01:31
e96040c to
2d654b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ceil integer attributes in undiscretize when clip_to_range is False
Previously, undiscretize only applied np.ceil and cast to int when both dtype == 'int' and clip_to_range == True. When clip_to_range == False, integer attributes returned un-ceiled float midpoints or uniform samples (such as 0.5) even when an integer sentinel was provided.
Always apply np.ceil when dtype == 'int' (preserving NaN when sentinel is None), and cast to int whenever clip_to_range is True or sentinel is an integer.