[b394751887] add compilerworks_metadata.yaml to Ranger output zip #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszydelko-google
requested review from
vladislav-sidorovich and
shevek-google
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDFS assessment job cannot work without compilerworks_metadata.yaml, so there was a need to add it.
Testing:
There was a problem with automatic testing, for test solution should be create integration/e2e test that checks if HDFS assessment is passing. There is no point of unit testing it - DumpMetadataTask was tested in different place, adding files to folder too. And there is no point of testing logic of totally different component.
I checked HDFS assessment before and after and fix works as it shows assessment job lszydelko-test-12.