-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ghc-source-gen compatible with GHC 9.10 #117
Conversation
fix GHC.SourceGen.Binds.Internal
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@wavewave thanks for the change! Do you mind updating the CI system? It's been a while since anybody contributes non-trivial changes, so our CI bitrotted. If you don'h a favorite one, feel free to steal from e.g. google/proto-lens |
@blackgnezdo : yes, I will try to fix it. :-) |
@jinwoo do you happen to be capable of approving this to get the workflow going? |
@blackgnezdo Looks like I can. But some tests are failing. |
Co-authored-by: Greg Steuck <[email protected]>
All tests seem to have passed now. @blackgnezdo Do you think it's okay to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wavewave!
Some nits to fix up before we can merge this.
Co-authored-by: Greg Steuck <[email protected]>
Co-authored-by: Greg Steuck <[email protected]>
Co-authored-by: Greg Steuck <[email protected]>
Co-authored-by: Greg Steuck <[email protected]>
eqnBndrs Co-authored-by: Greg Steuck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinwoo this looks pretty good to me now, WDYT?
Some tests seem to fail. I'll merge once they are fixed. |
All tests have passed. I'm merging now. Thanks, @wavewave and @blackgnezdo ! |
Adjusted with all the new API changes.