Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ghc-source-gen compatible with GHC 9.10 #117

Merged
merged 39 commits into from
Nov 6, 2024

Conversation

wavewave
Copy link
Contributor

Adjusted with all the new API changes.

Copy link

google-cla bot commented Oct 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wavewave wavewave mentioned this pull request Oct 25, 2024
@blackgnezdo
Copy link
Contributor

@wavewave thanks for the change!

Do you mind updating the CI system? It's been a while since anybody contributes non-trivial changes, so our CI bitrotted. If you don'h a favorite one, feel free to steal from e.g. google/proto-lens

@wavewave
Copy link
Contributor Author

@blackgnezdo : yes, I will try to fix it. :-)

@blackgnezdo
Copy link
Contributor

@jinwoo do you happen to be capable of approving this to get the workflow going?

@jinwoo
Copy link
Member

jinwoo commented Oct 28, 2024

@blackgnezdo Looks like I can. But some tests are failing.

Co-authored-by: Greg Steuck <[email protected]>
@jinwoo
Copy link
Member

jinwoo commented Nov 2, 2024

All tests seem to have passed now. @blackgnezdo Do you think it's okay to merge this?

Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wavewave!

Some nits to fix up before we can merge this.

Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinwoo this looks pretty good to me now, WDYT?

@jinwoo
Copy link
Member

jinwoo commented Nov 5, 2024

Some tests seem to fail. I'll merge once they are fixed.

@jinwoo
Copy link
Member

jinwoo commented Nov 6, 2024

All tests have passed. I'm merging now. Thanks, @wavewave and @blackgnezdo !

@jinwoo jinwoo merged commit 1f0ccfc into google:master Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants