openurl: fix URL scheme handling case-insensitive #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gofastasf
commented
Feb 7, 2025
Gofastasf
commented
- Add strings.ToLower for string normalization
- Align with RFC 3986 specifications for URL scheme handling
- Use direct map look up in ValidSchem func
- Add strings.ToLower for string normalization - Align with RFC 3986 specifications for URL scheme handling - Use direct map look up in ValidSchem func
vangent
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3521 +/- ##
==========================================
- Coverage 73.31% 73.30% -0.02%
==========================================
Files 113 113
Lines 15080 15079 -1
==========================================
- Hits 11056 11053 -3
- Misses 3259 3261 +2
Partials 765 765 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.