Skip to content

refactor: Fix revive.unnecessary-format lint issues #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Contributor

Changes:

  • Enabled the revive.unnecessary rule in golangci-lint config. This requires upgrading golangci-lint to version 2.2.2.
  • Fixes assert messages in TestRepositoriesService_GetAutomatedSecurityFixes.
  • Replaced t.Errorf with t.Error.
  • Replaced t.Fatalf with t.Fatal.
  • Replaced fmt.Fprintf with fmt.Fprint.
  • Replaced log.Fatalf with log.Fatal.

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (18877d9) to head (76c24d6).

Files with missing lines Patch % Lines
example/commitpr/main.go 0.00% 1 Missing ⚠️
example/verifyartifact/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3629   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         184      184           
  Lines       16174    16174           
=======================================
  Hits        14773    14773           
  Misses       1227     1227           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title refactor: fix revive.unnecessary-format lint issues refactor: Fix revive.unnecessary-format lint issues Jul 19, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit ff1666c into google:master Jul 19, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants